]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
bnx2x: Block nvram access when the device is inactive
authorEilon Greenstein <eilong@broadcom.com>
Wed, 14 Jan 2009 06:44:07 +0000 (06:44 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 20 Jan 2009 00:20:10 +0000 (16:20 -0800)
Don't dump eeprom when bnx2x adapter is down.  Running ethtool -e causes an eeh
without it when the device is down

Signed-off-by: Paul Larson <pl@linux.vnet.ibm.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bnx2x_main.c

index 7ee6a211f9ba1d9792dcb159db2f61568a13143e..ca5090c3341ee8a6c33994a1ae88c894b7c65cdf 100644 (file)
@@ -8107,6 +8107,9 @@ static int bnx2x_get_eeprom(struct net_device *dev,
        struct bnx2x *bp = netdev_priv(dev);
        int rc;
 
+       if (!netif_running(dev))
+               return -EAGAIN;
+
        DP(BNX2X_MSG_NVM, "ethtool_eeprom: cmd %d\n"
           DP_LEVEL "  magic 0x%x  offset 0x%x (%d)  len 0x%x (%d)\n",
           eeprom->cmd, eeprom->magic, eeprom->offset, eeprom->offset,