[PATCH] jbd2: sector_t conversion

JBD layer in-kernel block varibles type fixes to support >32 bit block number
and convert to sector_t type.

Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Dave Kleikamp <shaggy@austin.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c
index 44d68a113c73bd06560a5b004eba5942ec37c908..1a9ce8885220165f9ba26e1386759a447edd4851 100644 (file)
--- a/fs/jbd2/commit.c
+++ b/fs/jbd2/commit.c
@@ -293,7 +293,7 @@ void jbd2_journal_commit_transaction(journal_t *journal)
        int bufs;
        int flags;
        int err;
-       unsigned long blocknr;
+       sector_t blocknr;
        char *tagp = NULL;
        journal_header_t *header;
        journal_block_tag_t *tag = NULL;

diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 926ebcbf8a7aea8a3ef7a8b455ca4a8e44a430d2..259e8365ea1536e076578f20dce6be6100e6c75d 100644 (file)
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -271,7 +271,7 @@ static void journal_kill_thread(journal_t *journal)
 int jbd2_journal_write_metadata_buffer(transaction_t *transaction,
                                  struct journal_head  *jh_in,
                                  struct journal_head **jh_out,
-                                 unsigned long blocknr)
+                                 sector_t blocknr)
 {
        int need_copy_out = 0;
        int done_copy_out = 0;
@@ -555,7 +555,7 @@ int jbd2_log_wait_commit(journal_t *journal, tid_t tid)
  * Log buffer allocation routines:
  */
 
-int jbd2_journal_next_log_block(journal_t *journal, unsigned long *retp)
+int jbd2_journal_next_log_block(journal_t *journal, sector_t *retp)
 {
        unsigned long blocknr;
 
@@ -579,10 +579,10 @@ int jbd2_journal_next_log_block(journal_t *journal, unsigned long *retp)
  * ready.
  */
 int jbd2_journal_bmap(journal_t *journal, unsigned long blocknr,
-                unsigned long *retp)
+                sector_t *retp)
 {
        int err = 0;
-       unsigned long ret;
+       sector_t ret;
 
        if (journal->j_inode) {
                ret = bmap(journal->j_inode, blocknr);
@@ -618,7 +618,7 @@ int jbd2_journal_bmap(journal_t *journal, unsigned long blocknr,
 struct journal_head *jbd2_journal_get_descriptor_buffer(journal_t *journal)
 {
        struct buffer_head *bh;
-       unsigned long blocknr;
+       sector_t blocknr;
        int err;
 
        err = jbd2_journal_next_log_block(journal, &blocknr);
@@ -706,7 +706,7 @@ fail:
  */
 journal_t * jbd2_journal_init_dev(struct block_device *bdev,
                        struct block_device *fs_dev,
-                       int start, int len, int blocksize)
+                       sector_t start, int len, int blocksize)
 {
        journal_t *journal = journal_init_common();
        struct buffer_head *bh;
@@ -753,7 +753,7 @@ journal_t * jbd2_journal_init_inode (struct inode *inode)
        journal_t *journal = journal_init_common();
        int err;
        int n;
-       unsigned long blocknr;
+       sector_t blocknr;
 
        if (!journal)
                return NULL;
@@ -819,7 +819,7 @@ static void journal_fail_superblock (journal_t *journal)
 static int journal_reset(journal_t *journal)
 {
        journal_superblock_t *sb = journal->j_superblock;
-       unsigned long first, last;
+       sector_t first, last;
 
        first = be32_to_cpu(sb->s_first);
        last = be32_to_cpu(sb->s_maxlen);
@@ -853,7 +853,7 @@ static int journal_reset(journal_t *journal)
  **/
 int jbd2_journal_create(journal_t *journal)
 {
-       unsigned long blocknr;
+       sector_t blocknr;
        struct buffer_head *bh;
        journal_superblock_t *sb;
        int i, err;

diff --git a/fs/jbd2/recovery.c b/fs/jbd2/recovery.c
index 2486843adda0ac8b44182a29bf1c0d2ae1410e34..52054a83e717ff3dbd37f7bf4853137ca0aac393 100644 (file)
--- a/fs/jbd2/recovery.c
+++ b/fs/jbd2/recovery.c
@@ -70,7 +70,7 @@ static int do_readahead(journal_t *journal, unsigned int start)
 {
        int err;
        unsigned int max, nbufs, next;
-       unsigned long blocknr;
+       sector_t blocknr;
        struct buffer_head *bh;
 
        struct buffer_head * bufs[MAXBUF];
@@ -132,7 +132,7 @@ static int jread(struct buffer_head **bhp, journal_t *journal,
                 unsigned int offset)
 {
        int err;
-       unsigned long blocknr;
+       sector_t blocknr;
        struct buffer_head *bh;
 
        *bhp = NULL;
@@ -452,7 +452,7 @@ static int do_one_pass(journal_t *journal,
                                                "block %ld in log\n",
                                                err, io_block);
                                } else {
-                                       unsigned long blocknr;
+                                       sector_t blocknr;
 
                                        J_ASSERT(obh != NULL);
                                        blocknr = read_tag_block(tag_bytes,
@@ -592,7 +592,7 @@ static int scan_revoke_records(journal_t *journal, struct buffer_head *bh,
                record_len = 8;
 
        while (offset + record_len <= max) {
-               unsigned long blocknr;
+               sector_t blocknr;
                int err;
 
                if (record_len == 4)

diff --git a/fs/jbd2/revoke.c b/fs/jbd2/revoke.c
index 8aac875bd301865c81aa0e8f93e6b5f00c7e1ddc..3310a1d7ace9d79cfc135c24703b64142c55be1b 100644 (file)
--- a/fs/jbd2/revoke.c
+++ b/fs/jbd2/revoke.c
@@ -81,7 +81,7 @@ struct jbd2_revoke_record_s
 {
        struct list_head  hash;
        tid_t             sequence;     /* Used for recovery only */
-       unsigned long     blocknr;
+       sector_t          blocknr;
 };
 
 
@@ -106,17 +106,18 @@ static void flush_descriptor(journal_t *, struct journal_head *, int);
 /* Utility functions to maintain the revoke table */
 
 /* Borrowed from buffer.c: this is a tried and tested block hash function */
-static inline int hash(journal_t *journal, unsigned long block)
+static inline int hash(journal_t *journal, sector_t block)
 {
        struct jbd2_revoke_table_s *table = journal->j_revoke;
        int hash_shift = table->hash_shift;
+       int hash = (int)block ^ (int)((block >> 31) >> 1);
 
-       return ((block << (hash_shift - 6)) ^
-               (block >> 13) ^
-               (block << (hash_shift - 12))) & (table->hash_size - 1);
+       return ((hash << (hash_shift - 6)) ^
+               (hash >> 13) ^
+               (hash << (hash_shift - 12))) & (table->hash_size - 1);
 }
 
-static int insert_revoke_hash(journal_t *journal, unsigned long blocknr,
+static int insert_revoke_hash(journal_t *journal, sector_t blocknr,
                              tid_t seq)
 {
        struct list_head *hash_list;
@@ -146,7 +147,7 @@ oom:
 /* Find a revoke record in the journal's hash table. */
 
 static struct jbd2_revoke_record_s *find_revoke_record(journal_t *journal,
-                                                     unsigned long blocknr)
+                                                     sector_t blocknr)
 {
        struct list_head *hash_list;
        struct jbd2_revoke_record_s *record;
@@ -325,7 +326,7 @@ void jbd2_journal_destroy_revoke(journal_t *journal)
  * by one.
  */
 
-int jbd2_journal_revoke(handle_t *handle, unsigned long blocknr,
+int jbd2_journal_revoke(handle_t *handle, sector_t blocknr,
                   struct buffer_head *bh_in)
 {
        struct buffer_head *bh = NULL;
@@ -394,7 +395,7 @@ int jbd2_journal_revoke(handle_t *handle, unsigned long blocknr,
                }
        }
 
-       jbd_debug(2, "insert revoke for block %lu, bh_in=%p\n", blocknr, bh_in);
+       jbd_debug(2, "insert revoke for block %llu, bh_in=%p\n",blocknr, bh_in);
        err = insert_revoke_hash(journal, blocknr,
                                handle->h_transaction->t_tid);
        BUFFER_TRACE(bh_in, "exit");
@@ -649,7 +650,7 @@ static void flush_descriptor(journal_t *journal,
  */
 
 int jbd2_journal_set_revoke(journal_t *journal,
-                      unsigned long blocknr,
+                      sector_t blocknr,
                       tid_t sequence)
 {
        struct jbd2_revoke_record_s *record;
@@ -673,7 +674,7 @@ int jbd2_journal_set_revoke(journal_t *journal,
  */
 
 int jbd2_journal_test_revoke(journal_t *journal,
-                       unsigned long blocknr,
+                       sector_t blocknr,
                        tid_t sequence)
 {
        struct jbd2_revoke_record_s *record;

diff --git a/include/linux/ext4_jbd2.h b/include/linux/ext4_jbd2.h
index f69af60d76929d595329b3f08b6856f502e3123b..72dd631912e4aaee12ed65e6fb343bb7dfb5f4e0 100644 (file)
--- a/include/linux/ext4_jbd2.h
+++ b/include/linux/ext4_jbd2.h
@@ -154,7 +154,7 @@ __ext4_journal_forget(const char *where, handle_t *handle, struct buffer_head *b
 
 static inline int
 __ext4_journal_revoke(const char *where, handle_t *handle,
-                     unsigned long blocknr, struct buffer_head *bh)
+                     ext4_fsblk_t blocknr, struct buffer_head *bh)
 {
        int err = jbd2_journal_revoke(handle, blocknr, bh);
        if (err)

diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
index 5e5aa64f12618a333dab4943a27426d0f655303b..3c939c844a7deb6e4458e03bfc66a18fbb84f924 100644 (file)
--- a/include/linux/jbd2.h
+++ b/include/linux/jbd2.h
@@ -741,7 +741,7 @@ struct journal_s
         */
        struct block_device     *j_dev;
        int                     j_blocksize;
-       unsigned long           j_blk_offset;
+       sector_t                j_blk_offset;
 
        /*
         * Device which holds the client fs.  For internal journal this will be
@@ -860,7 +860,7 @@ extern void __journal_clean_data_list(transaction_t *transaction);
 
 /* Log buffer allocation */
 extern struct journal_head * jbd2_journal_get_descriptor_buffer(journal_t *);
-int jbd2_journal_next_log_block(journal_t *, unsigned long *);
+int jbd2_journal_next_log_block(journal_t *, sector_t *);
 
 /* Commit management */
 extern void jbd2_journal_commit_transaction(journal_t *);
@@ -875,7 +875,7 @@ extern int
 jbd2_journal_write_metadata_buffer(transaction_t         *transaction,
                              struct journal_head  *jh_in,
                              struct journal_head **jh_out,
-                             unsigned long        blocknr);
+                             sector_t     blocknr);
 
 /* Transaction locking */
 extern void            __wait_on_journal (journal_t *);
@@ -923,7 +923,7 @@ extern void  jbd2_journal_unlock_updates (journal_t *);
 
 extern journal_t * jbd2_journal_init_dev(struct block_device *bdev,
                                struct block_device *fs_dev,
-                               int start, int len, int bsize);
+                               sector_t start, int len, int bsize);
 extern journal_t * jbd2_journal_init_inode (struct inode *);
 extern int        jbd2_journal_update_format (journal_t *);
 extern int        jbd2_journal_check_used_features
@@ -944,7 +944,7 @@ extern void    jbd2_journal_abort      (journal_t *, int);
 extern int        jbd2_journal_errno      (journal_t *);
 extern void       jbd2_journal_ack_err    (journal_t *);
 extern int        jbd2_journal_clear_err  (journal_t *);
-extern int        jbd2_journal_bmap(journal_t *, unsigned long, unsigned long *);
+extern int        jbd2_journal_bmap(journal_t *, unsigned long, sector_t *);
 extern int        jbd2_journal_force_commit(journal_t *);
 
 /*
@@ -977,14 +977,13 @@ extern void          jbd2_journal_destroy_revoke_caches(void);
 extern int        jbd2_journal_init_revoke_caches(void);
 
 extern void       jbd2_journal_destroy_revoke(journal_t *);
-extern int        jbd2_journal_revoke (handle_t *,
-                               unsigned long, struct buffer_head *);
+extern int        jbd2_journal_revoke (handle_t *, sector_t, struct buffer_head *);
 extern int        jbd2_journal_cancel_revoke(handle_t *, struct journal_head *);
 extern void       jbd2_journal_write_revoke_records(journal_t *, transaction_t *);
 
 /* Recovery revoke support */
-extern int     jbd2_journal_set_revoke(journal_t *, unsigned long, tid_t);
-extern int     jbd2_journal_test_revoke(journal_t *, unsigned long, tid_t);
+extern int     jbd2_journal_set_revoke(journal_t *, sector_t, tid_t);
+extern int     jbd2_journal_test_revoke(journal_t *, sector_t, tid_t);
 extern void    jbd2_journal_clear_revoke(journal_t *);
 extern void    jbd2_journal_switch_revoke_table(journal_t *journal);