]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
Fix container_of() usage
authorAlexey Dobriyan <adobriyan@sw.ru>
Fri, 8 Feb 2008 12:20:14 +0000 (04:20 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Fri, 8 Feb 2008 17:22:32 +0000 (09:22 -0800)
Using "attr" twice is not OK, because it effectively prohibits such
container_of() on variables not named "attr".

Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/sh/kernel/cpu/sh4/sq.c
drivers/lguest/lguest_device.c

index 3008c00eea6b6c269e7fa6bde3e2e43ca4d0f4b8..8250e017bd4eaac43989cfa037be64b4c59688fe 100644 (file)
@@ -263,7 +263,7 @@ struct sq_sysfs_attr {
        ssize_t (*store)(const char *buf, size_t count);
 };
 
-#define to_sq_sysfs_attr(attr) container_of(attr, struct sq_sysfs_attr, attr)
+#define to_sq_sysfs_attr(a)    container_of(a, struct sq_sysfs_attr, attr)
 
 static ssize_t sq_sysfs_show(struct kobject *kobj, struct attribute *attr,
                             char *buf)
index 84f85e23cca7a65a86b3ffa3647953373c5339b3..1b2ec0bf5eb11d9fedfeb65b035e89efe683d013 100644 (file)
@@ -47,7 +47,7 @@ struct lguest_device {
 /* Since the virtio infrastructure hands us a pointer to the virtio_device all
  * the time, it helps to have a curt macro to get a pointer to the struct
  * lguest_device it's enclosed in.  */
-#define to_lgdev(vdev) container_of(vdev, struct lguest_device, vdev)
+#define to_lgdev(vd) container_of(vd, struct lguest_device, vdev)
 
 /*D:130
  * Device configurations