]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
libata: drop ata_dev_select() from ata_dev_read_id
authorTejun Heo <htejun@gmail.com>
Tue, 25 Mar 2008 13:16:39 +0000 (22:16 +0900)
committerJeff Garzik <jgarzik@redhat.com>
Thu, 17 Apr 2008 19:44:18 +0000 (15:44 -0400)
There is no reason to issue device select in read_id, it will be done
by ops->qc_issue() when IDENTIFY[_PACKET] is issued via
ata_exec_internal().

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/libata-core.c

index 345f4a6865a881bb88c4da40797c9c478f12fec0..7860d9f60ae458d310483cca4ffb9444b1a9d4ea 100644 (file)
@@ -2156,7 +2156,6 @@ int ata_dev_read_id(struct ata_device *dev, unsigned int *p_class,
        if (ata_msg_ctl(ap))
                ata_dev_printk(dev, KERN_DEBUG, "%s: ENTER\n", __func__);
 
-       ata_dev_select(ap, dev->devno, 1, 1); /* select device 0/1 */
  retry:
        ata_tf_init(dev, &tf);