]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
ide: add ide_read_device() helper
authorBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Wed, 23 Jul 2008 17:55:54 +0000 (19:55 +0200)
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Wed, 23 Jul 2008 17:55:54 +0000 (19:55 +0200)
Add ide_read_device() helper and convert do_probe() to use it
instead of ->INB.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
drivers/ide/ide-probe.c

index 970464317bd71cad1f424655960b4c2acf8a7ec6..21cea45e9f21e9250bf1941ddfd50ed377f511a8 100644 (file)
@@ -410,6 +410,18 @@ static int ide_busy_sleep(ide_hwif_t *hwif)
        return 1;
 }
 
+static u8 ide_read_device(ide_drive_t *drive)
+{
+       ide_task_t task;
+
+       memset(&task, 0, sizeof(task));
+       task.tf_flags = IDE_TFLAG_IN_DEVICE;
+
+       drive->hwif->tf_read(drive, &task);
+
+       return task.tf.device;
+}
+
 /**
  *     do_probe                -       probe an IDE device
  *     @drive: drive to probe
@@ -434,7 +446,6 @@ static int ide_busy_sleep(ide_hwif_t *hwif)
 static int do_probe (ide_drive_t *drive, u8 cmd)
 {
        ide_hwif_t *hwif = HWIF(drive);
-       struct ide_io_ports *io_ports = &hwif->io_ports;
        int rc;
        u8 stat;
 
@@ -455,8 +466,8 @@ static int do_probe (ide_drive_t *drive, u8 cmd)
        msleep(50);
        SELECT_DRIVE(drive);
        msleep(50);
-       if (hwif->INB(io_ports->device_addr) != drive->select.all &&
-           !drive->present) {
+
+       if (ide_read_device(drive) != drive->select.all && !drive->present) {
                if (drive->select.b.unit != 0) {
                        /* exit with drive0 selected */
                        SELECT_DRIVE(&hwif->drives[0]);