]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
x86: HPET: convert WARN_ON to WARN_ON_ONCE
authorMatt Fleming <mjf@gentoo.org>
Sun, 2 Nov 2008 16:04:18 +0000 (16:04 +0000)
committerThomas Gleixner <tglx@apollo.(none)>
Mon, 10 Nov 2008 16:38:07 +0000 (17:38 +0100)
It is possible to flood the console with call traces if the WARN_ON
condition is true because of the frequency with which this function is
called.

Signed-off-by: Matt Fleming <mjf@gentoo.org>
Cc: mingo@elte.hu
Cc: venkatesh.pallipadi@intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
arch/x86/kernel/hpet.c

index 77017e834cf7178b4fceb957a7e706ec4f2d220a..f10f9461a43daf25f3cb05a391f51966fe86860e 100644 (file)
@@ -322,7 +322,7 @@ static int hpet_next_event(unsigned long delta,
         * what we wrote hit the chip before we compare it to the
         * counter.
         */
-       WARN_ON((u32)hpet_readl(HPET_T0_CMP) != cnt);
+       WARN_ON_ONCE((u32)hpet_readl(HPET_T0_CMP) != cnt);
 
        return (s32)((u32)hpet_readl(HPET_COUNTER) - cnt) >= 0 ? -ETIME : 0;
 }