]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
IO resources: fix/remove printk
authorIngo Molnar <mingo@elte.hu>
Thu, 4 Sep 2008 19:26:06 +0000 (21:26 +0200)
committerIngo Molnar <mingo@elte.hu>
Thu, 4 Sep 2008 20:08:24 +0000 (22:08 +0200)
Andrew Morton noticed that the printk in kernel/resource.c was buggy:

| start and end have type resource_size_t.  Such types CANNOT be printed
| unless cast to a known type.
|
| Because there is a %s following an incorrect %lld, the above code will
| crash the machine.

... and it's probably quite unneeded as well, so remove it.

Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/resource.c

index 414d6fc9131ea3dde1c98087d9cd4ede65cf19f1..fc59dcc4795b772c9aae54f266d50d9a79703db2 100644 (file)
@@ -549,13 +549,9 @@ static void __init __reserve_region_with_split(struct resource *root,
        }
 
        if (!res) {
-               printk(KERN_DEBUG "    __reserve_region_with_split: (%s) [%llx, %llx], res: (%s) [%llx, %llx]\n",
-                        conflict->name, conflict->start, conflict->end,
-                        name, start, end);
-
                /* failed, split and try again */
 
-               /* conflict coverred whole area */
+               /* conflict covered whole area */
                if (conflict->start <= start && conflict->end >= end)
                        return;