]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[PATCH] ioremap balanced with iounmap for drivers/video/hpfb
authorAmol Lad <amol@verismonetworks.com>
Fri, 8 Dec 2006 10:40:10 +0000 (02:40 -0800)
committerLinus Torvalds <torvalds@woody.osdl.org>
Fri, 8 Dec 2006 16:29:04 +0000 (08:29 -0800)
ioremap must be balanced by an iounmap and failing to do so can result in a
memory leak.

Signed-off-by: Amol Lad <amol@verismonetworks.com>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/video/hpfb.c

index 91cf3b577d156c4b78dea835d24b80b61461634f..9ab9b839a0f5e57cbf643c9bd7c238388d33ba9a 100644 (file)
@@ -295,6 +295,8 @@ static int __init hpfb_init_one(unsigned long phys_base, unsigned long virt_base
 
        if (register_framebuffer(&fb_info) < 0) {
                fb_dealloc_cmap(&fb_info.cmap);
+               iounmap(fb_info.screen_base);
+               fb_info.screen_base = NULL;
                return 1;
        }