]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
Revert "ide: respect current DMA setting during resume"
authorBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Mon, 8 Dec 2008 16:42:35 +0000 (17:42 +0100)
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Mon, 8 Dec 2008 16:42:35 +0000 (17:42 +0100)
This reverts commit e9eb8388306364295308132265c00bea685f409f since
it could break resume (thanks to Paul Collins for the report).

I'll look into sorting this out properly for 2.6.29
but for 2.6.28 it is the best to just revert my patch.

Reported-by: Paul Collins <paul@burly.ondioline.org>
Cc: rjw@sisk.pl
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
drivers/ide/ide-io.c

index 7d275b2af3eb74a0c4db266fd4d9c7540f061793..cc35d6dbd41026d02cdc1ab5a32085cc8c63e0db 100644 (file)
@@ -208,8 +208,10 @@ static ide_startstop_t ide_start_power_step(ide_drive_t *drive, struct request *
                 */
                if (drive->hwif->dma_ops == NULL)
                        break;
-               if (drive->dev_flags & IDE_DFLAG_USING_DMA)
-                       ide_set_dma(drive);
+               /*
+                * TODO: respect IDE_DFLAG_USING_DMA
+                */
+               ide_set_dma(drive);
                break;
        }