]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
phy devices: use same arg types
authorRandy Dunlap <randy.dunlap@oracle.com>
Mon, 5 Feb 2007 18:44:20 +0000 (10:44 -0800)
committerJeff Garzik <jeff@garzik.org>
Fri, 9 Feb 2007 21:34:13 +0000 (16:34 -0500)
sparse complains about differing types from prototype to
definition, so change the u32 to phy_interface_t:

drivers/net/phy/phy_device.c:140:19: error: symbol 'phy_connect' redeclared with different type (originally declared at include/linux/phy.h:362) - incompatible argument 5 (different signedness)
drivers/net/phy/phy_device.c:190:19: error: symbol 'phy_attach' redeclared with different type (originally declared at include/linux/phy.h:360) - incompatible argument 4 (different signedness)

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/net/phy/phy_device.c

index a4d7529ef41515d464282c883fe6c191b8b4366d..deda210c844ea11903a21e4035eba870c0b637a7 100644 (file)
@@ -139,7 +139,7 @@ void phy_prepare_link(struct phy_device *phydev,
  */
 struct phy_device * phy_connect(struct net_device *dev, const char *phy_id,
                void (*handler)(struct net_device *), u32 flags,
-               u32 interface)
+               phy_interface_t interface)
 {
        struct phy_device *phydev;
 
@@ -188,7 +188,7 @@ static int phy_compare_id(struct device *dev, void *data)
 }
 
 struct phy_device *phy_attach(struct net_device *dev,
-               const char *phy_id, u32 flags, u32 interface)
+               const char *phy_id, u32 flags, phy_interface_t interface)
 {
        struct bus_type *bus = &mdio_bus_type;
        struct phy_device *phydev;