]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[TCP]: Rexmit hint must be cleared instead of setting it
authorIlpo Järvinen <ilpo.jarvinen@helsinki.fi>
Wed, 28 Mar 2007 19:06:37 +0000 (12:06 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Wed, 10 Oct 2007 23:47:51 +0000 (16:47 -0700)
Stupid error from my side. Even though now that I noticed this,
I hoped it would have been an optimization but no, the counter
hint is then incorrect. Thus clearing is necessary for now (I
still suspect though that this path is never executed).

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_input.c

index 7d843c42938154924aa6521c60df83d8a280ba42..0aa17243d3694e655ffdbf7e5e0598c2f2b271a4 100644 (file)
@@ -1776,7 +1776,7 @@ static void tcp_verify_retransmit_hint(struct tcp_sock *tp,
        if ((tp->retransmit_skb_hint != NULL) &&
            before(TCP_SKB_CB(skb)->seq,
            TCP_SKB_CB(tp->retransmit_skb_hint)->seq))
-               tp->retransmit_skb_hint = skb;
+               tp->retransmit_skb_hint = NULL;
 }
 
 /* Mark head of queue up as lost. */