]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
gpu/drm, x86, PAT: PAT support for io_mapping_*
authorVenkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Wed, 25 Feb 2009 01:35:14 +0000 (17:35 -0800)
committerIngo Molnar <mingo@elte.hu>
Wed, 25 Feb 2009 12:09:52 +0000 (13:09 +0100)
Make io_mapping_create_wc and io_mapping_free go through PAT to make sure
that there are no memory type aliases.

Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Eric Anholt <eric@anholt.net>
Cc: Keith Packard <keithp@keithp.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/include/asm/iomap.h
arch/x86/mm/iomap_32.c
include/linux/io-mapping.h

index 86af26091d6c3c2146da4e5f6f3abbfd6cb165ba..bd46495ff7de3a7e7e4db0d2c6b02027b7e95057 100644 (file)
 #include <asm/tlbflush.h>
 
 int
-is_io_mapping_possible(resource_size_t base, unsigned long size);
+reserve_io_memtype_wc(u64 base, unsigned long size, pgprot_t *prot);
+
+void
+free_io_memtype(u64 base, unsigned long size);
 
 void *
 iomap_atomic_prot_pfn(unsigned long pfn, enum km_type type, pgprot_t prot);
index 6c2b1af16926798c7b28e8287ad0ebad64188897..94596f794b1b83ebba429b22ed629134da673d40 100644 (file)
 #include <linux/module.h>
 
 #ifdef CONFIG_X86_PAE
-int
+static int
 is_io_mapping_possible(resource_size_t base, unsigned long size)
 {
        return 1;
 }
 #else
-int
+static int
 is_io_mapping_possible(resource_size_t base, unsigned long size)
 {
        /* There is no way to map greater than 1 << 32 address without PAE */
@@ -38,6 +38,44 @@ is_io_mapping_possible(resource_size_t base, unsigned long size)
 }
 #endif
 
+int
+reserve_io_memtype_wc(u64 base, unsigned long size, pgprot_t *prot)
+{
+       unsigned long ret_flag;
+
+       if (!is_io_mapping_possible(base, size))
+               goto out_err;
+
+       if (!pat_enabled) {
+               *prot = pgprot_noncached(PAGE_KERNEL);
+               return 0;
+       }
+
+       if (reserve_memtype(base, base + size, _PAGE_CACHE_WC, &ret_flag))
+               goto out_err;
+
+       if (ret_flag == _PAGE_CACHE_WB)
+               goto out_free;
+
+       if (kernel_map_sync_memtype(base, size, ret_flag))
+               goto out_free;
+
+       *prot = __pgprot(__PAGE_KERNEL | ret_flag);
+       return 0;
+
+out_free:
+       free_memtype(base, base + size);
+out_err:
+       return -EINVAL;
+}
+
+void
+free_io_memtype(u64 base, unsigned long size)
+{
+       if (pat_enabled)
+               free_memtype(base, base + size);
+}
+
 /* Map 'pfn' using fixed map 'type' and protections 'prot'
  */
 void *
index cbc2f0cd631ba1f58b4c5f937dbcffecab48a36a..f1ed66c437873d6baf47decaccd5999eb8b63a87 100644 (file)
@@ -49,8 +49,9 @@ static inline struct io_mapping *
 io_mapping_create_wc(resource_size_t base, unsigned long size)
 {
        struct io_mapping *iomap;
+       pgprot_t prot;
 
-       if (!is_io_mapping_possible(base, size))
+       if (!reserve_io_memtype_wc(base, size, &prot))
                return NULL;
 
        iomap = kmalloc(sizeof(*iomap), GFP_KERNEL);
@@ -59,13 +60,14 @@ io_mapping_create_wc(resource_size_t base, unsigned long size)
 
        iomap->base = base;
        iomap->size = size;
-       iomap->prot = pgprot_writecombine(__pgprot(__PAGE_KERNEL));
+       iomap->prot = prot;
        return iomap;
 }
 
 static inline void
 io_mapping_free(struct io_mapping *mapping)
 {
+       free_io_memtype(mapping->base, mapping->size);
        kfree(mapping);
 }