]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
i2c: Add missing KERN_* constants to printks
authorFrank Seidel <frank@f-seidel.de>
Sat, 28 Mar 2009 20:34:42 +0000 (21:34 +0100)
committerJean Delvare <khali@linux-fr.org>
Sat, 28 Mar 2009 20:34:42 +0000 (21:34 +0100)
According to kerneljanitors todo list all printk calls (beginning
a new line) should have an according KERN_* constant.
Those are the missing pieces here for the i2c subsystem.

Signed-off-by: Frank Seidel <frank@f-seidel.de>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
drivers/i2c/algos/i2c-algo-pcf.c
drivers/i2c/busses/i2c-pca-isa.c
drivers/i2c/busses/i2c-powermac.c
drivers/i2c/busses/i2c-pxa.c

index 65a769f3ae7985020b813afb643a8f2eba056d9a..d31147e1077434a8cee051950df6ce92b0df3089 100644 (file)
@@ -61,7 +61,7 @@ static int i2c_debug;
 
 static void i2c_start(struct i2c_algo_pcf_data *adap)
 {
-       DEBPROTO(printk("S "));
+       DEBPROTO(printk(KERN_DEBUG "S "));
        set_pcf(adap, 1, I2C_PCF_START);
 }
 
index 4aa8138cb0a97ef7a7a8ce2dd79ebc8f07d30302..c420a7c0f3e454bbedf90cf72897733d618f6d62 100644 (file)
@@ -49,7 +49,8 @@ static void pca_isa_writebyte(void *pd, int reg, int val)
 {
 #ifdef DEBUG_IO
        static char *names[] = { "T/O", "DAT", "ADR", "CON" };
-       printk("*** write %s at %#lx <= %#04x\n", names[reg], base+reg, val);
+       printk(KERN_DEBUG "*** write %s at %#lx <= %#04x\n", names[reg],
+              base+reg, val);
 #endif
        outb(val, base+reg);
 }
@@ -60,7 +61,7 @@ static int pca_isa_readbyte(void *pd, int reg)
 #ifdef DEBUG_IO
        {
                static char *names[] = { "STA", "DAT", "ADR", "CON" };
-               printk("*** read  %s => %#04x\n", names[reg], res);
+               printk(KERN_DEBUG "*** read  %s => %#04x\n", names[reg], res);
        }
 #endif
        return res;
index 60ca91745e55cebc37ae21a8857d00348a819f00..3c9d71f60187ac6f979027238e31d4230cd5a764 100644 (file)
@@ -191,7 +191,8 @@ static int __devexit i2c_powermac_remove(struct platform_device *dev)
        i2c_set_adapdata(adapter, NULL);
        /* We aren't that prepared to deal with this... */
        if (rc)
-               printk("i2c-powermac.c: Failed to remove bus %s !\n",
+               printk(KERN_WARNING
+                      "i2c-powermac.c: Failed to remove bus %s !\n",
                       adapter->name);
        platform_set_drvdata(dev, NULL);
        kfree(adapter);
index bdb1f7510e91555209bdf5dedfd20a48f50e1aba..c1405c8f6ba5645a163519a5d5cbbd7ac2021f6a 100644 (file)
@@ -210,11 +210,12 @@ static irqreturn_t i2c_pxa_handler(int this_irq, void *dev_id);
 static void i2c_pxa_scream_blue_murder(struct pxa_i2c *i2c, const char *why)
 {
        unsigned int i;
-       printk("i2c: error: %s\n", why);
-       printk("i2c: msg_num: %d msg_idx: %d msg_ptr: %d\n",
+       printk(KERN_ERR "i2c: error: %s\n", why);
+       printk(KERN_ERR "i2c: msg_num: %d msg_idx: %d msg_ptr: %d\n",
                i2c->msg_num, i2c->msg_idx, i2c->msg_ptr);
-       printk("i2c: ICR: %08x ISR: %08x\n"
-              "i2c: log: ", readl(_ICR(i2c)), readl(_ISR(i2c)));
+       printk(KERN_ERR "i2c: ICR: %08x ISR: %08x\n",
+              readl(_ICR(i2c)), readl(_ISR(i2c)));
+       printk(KERN_DEBUG "i2c: log: ");
        for (i = 0; i < i2c->irqlogidx; i++)
                printk("[%08x:%08x] ", i2c->isrlog[i], i2c->icrlog[i]);
        printk("\n");