]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[CIFS] cifs: remove pointless lock and unlock of GlobalMid_Lock in header_assemble
authorJeff Layton <jlayton@redhat.com>
Sun, 12 Oct 2008 13:34:11 +0000 (13:34 +0000)
committerSteve French <sfrench@us.ibm.com>
Sun, 12 Oct 2008 13:34:11 +0000 (13:34 +0000)
We lock GlobalMid_Lock in header_assemble and then immediately unlock it
again without doing anything. Not sure what this was intended to do, but
remove it.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
fs/cifs/misc.c

index 654d972a88f4022f9ec7d60a7277e21201b5bfb0..88786ba02d277fac25923893c29bb96206e42827 100644 (file)
@@ -311,8 +311,6 @@ header_assemble(struct smb_hdr *buffer, char smb_command /* command */ ,
        buffer->Flags2 = SMBFLG2_KNOWS_LONG_NAMES;
        buffer->Pid = cpu_to_le16((__u16)current->tgid);
        buffer->PidHigh = cpu_to_le16((__u16)(current->tgid >> 16));
-       spin_lock(&GlobalMid_Lock);
-       spin_unlock(&GlobalMid_Lock);
        if (treeCon) {
                buffer->Tid = treeCon->tid;
                if (treeCon->ses) {