]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[TCP]: lower stack usage in cookie_hash() function
authorEric Dumazet <dada1@cosmosbay.com>
Thu, 7 Feb 2008 09:40:19 +0000 (10:40 +0100)
committerYOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Tue, 4 Mar 2008 06:18:21 +0000 (15:18 +0900)
400 bytes allocated on stack might be a litle bit too much. Using a
per_cpu var is more friendly.

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
net/ipv4/syncookies.c

index f470fe4511dbf6a03205e3690ff616dfdf2c8ffa..177da14f6b1454d64d9ec70d30b15415d392fc5b 100644 (file)
@@ -35,10 +35,12 @@ module_init(init_syncookies);
 #define COOKIEBITS 24  /* Upper bits store count */
 #define COOKIEMASK (((__u32)1 << COOKIEBITS) - 1)
 
+static DEFINE_PER_CPU(__u32, cookie_scratch)[16 + 5 + SHA_WORKSPACE_WORDS];
+
 static u32 cookie_hash(__be32 saddr, __be32 daddr, __be16 sport, __be16 dport,
                       u32 count, int c)
 {
-       __u32 tmp[16 + 5 + SHA_WORKSPACE_WORDS];
+       __u32 *tmp = __get_cpu_var(cookie_scratch);
 
        memcpy(tmp + 3, syncookie_secret[c], sizeof(syncookie_secret[c]));
        tmp[0] = (__force u32)saddr;