]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
hwmon: (ams) Fix permissions on 'joystick' module parameter
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 17 Oct 2008 15:51:12 +0000 (17:51 +0200)
committerJean Delvare <khali@mahadeva.delvare>
Fri, 17 Oct 2008 15:51:12 +0000 (17:51 +0200)
We should not allow writes to the 'joystick' module parameters since
writing there will not trigger creation of the input device. Disable
writes since we provide alternative way of enabling input device via
AMS device's sysfs attribute.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
drivers/hwmon/ams/ams-input.c

index 7b81e0c2c2d9bb4f4a8bbacbfa0024e1edda03f9..48dbf7d6a66d9e6a14577667868901087abaff07 100644 (file)
 #include "ams.h"
 
 static unsigned int joystick;
-module_param(joystick, bool, 0644);
+module_param(joystick, bool, S_IRUGO);
 MODULE_PARM_DESC(joystick, "Enable the input class device on module load");
 
 static unsigned int invert;
-module_param(invert, bool, 0644);
+module_param(invert, bool, S_IWUSR | S_IRUGO);
 MODULE_PARM_DESC(invert, "Invert input data on X and Y axis");
 
 static void ams_idev_poll(struct input_polled_dev *dev)