[MIPS] fix sparse warning about setup_early_printk()

This patch fixes the following sparse warning:

<<<<<<<<

arch/mips/kernel/early_printk.c:35:13: warning: symbol 'setup_early_printk'
was not declared. Should it be static?

<<<<<<<<

The fix is to define a prototype of the setup_early_printk() function and
to include the appropriate header into arch/mips/kernel/early_printk.c.

[Ralf: Sorted includes again]

Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

diff --git a/arch/mips/kernel/early_printk.c b/arch/mips/kernel/early_printk.c
index 9dccfa4752b20b2eacdd366bf8be7c1f9c61a085..9ae813eb782e9cebe160df532b113e456d7fe799 100644 (file)
--- a/arch/mips/kernel/early_printk.c
+++ b/arch/mips/kernel/early_printk.c
@@ -10,6 +10,8 @@
 #include <linux/console.h>
 #include <linux/init.h>
 
+#include <asm/setup.h>
+
 extern void prom_putchar(char);
 
 static void __init

diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
index c04e4e3afede66fd11e7b9f7ed9b7f27d104ead1..8af84867e74d6cfda9c801b874ea355c6b71bf55 100644 (file)
--- a/arch/mips/kernel/setup.c
+++ b/arch/mips/kernel/setup.c
@@ -550,11 +550,7 @@ void __init setup_arch(char **cmdline_p)
        prom_init();
 
 #ifdef CONFIG_EARLY_PRINTK
-       {
-               extern void setup_early_printk(void);
-
-               setup_early_printk();
-       }
+       setup_early_printk();
 #endif
        cpu_report();
        check_bugs_early();

diff --git a/include/asm-mips/setup.h b/include/asm-mips/setup.h
index 70009a902639170fcf929938228e320635803f74..883f59bfa097f26f437c465596b5ab26d956c0db 100644 (file)
--- a/include/asm-mips/setup.h
+++ b/include/asm-mips/setup.h
@@ -3,4 +3,6 @@
 
 #define COMMAND_LINE_SIZE      256
 
+extern void setup_early_printk(void);
+
 #endif /* __SETUP_H */