]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[SCSI] zfcp: Remove qtcb dump to kernel log
authorMartin Peschke <mp3@de.ibm.com>
Thu, 27 Mar 2008 13:21:57 +0000 (14:21 +0100)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Mon, 7 Apr 2008 17:19:03 +0000 (12:19 -0500)
Is not appropriate to printk() tons of hardware trace data.

Signed-off-by: Martin Peschke <mp3@de.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/s390/scsi/zfcp_fsf.c

index 2ed3c7b48882bc3f06f2b2cfe3407529ab1905c8..264f5f1bdde69a8df85056769a904886ac769c3f 100644 (file)
@@ -284,37 +284,6 @@ zfcp_fsf_protstatus_eval(struct zfcp_fsf_req *fsf_req)
                goto skip_protstatus;
        }
 
-       /* log additional information provided by FSF (if any) */
-       if (likely(qtcb->header.log_length)) {
-               /* do not trust them ;-) */
-               if (unlikely(qtcb->header.log_start >
-                            sizeof(struct fsf_qtcb))) {
-                       ZFCP_LOG_NORMAL
-                           ("bug: ULP (FSF logging) log data starts "
-                            "beyond end of packet header. Ignored. "
-                            "(start=%i, size=%li)\n",
-                            qtcb->header.log_start,
-                            sizeof(struct fsf_qtcb));
-                       goto forget_log;
-               }
-               if (unlikely((size_t) (qtcb->header.log_start +
-                                      qtcb->header.log_length) >
-                            sizeof(struct fsf_qtcb))) {
-                       ZFCP_LOG_NORMAL("bug: ULP (FSF logging) log data ends "
-                                       "beyond end of packet header. Ignored. "
-                                       "(start=%i, length=%i, size=%li)\n",
-                                       qtcb->header.log_start,
-                                       qtcb->header.log_length,
-                                       sizeof(struct fsf_qtcb));
-                       goto forget_log;
-               }
-               ZFCP_LOG_TRACE("ULP log data: \n");
-               ZFCP_HEX_DUMP(ZFCP_LOG_LEVEL_TRACE,
-                             (char *) qtcb + qtcb->header.log_start,
-                             qtcb->header.log_length);
-       }
- forget_log:
-
        /* evaluate FSF Protocol Status */
        switch (qtcb->prefix.prot_status) {