[PATCH] Char: mxser_new, kill unneeded memsets

mxser_new, kill unneeded memsets

There is no need to re-zero static global variables' memory, hence memsets
doing this are useless.  alloc_tty_struct also zeroes allocated memory:
another candidate for removing.

This fixes also a bug -- global structures are cleaned up after
initialization of some its parts.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

diff --git a/drivers/char/mxser_new.c b/drivers/char/mxser_new.c
index 5a4c80d38c6522cc64058bb93e3f6d8c1059a671..4ca97c4401d5e1192ba807b66893b6866ba41786 100644 (file)
--- a/drivers/char/mxser_new.c
+++ b/drivers/char/mxser_new.c
@@ -704,7 +704,6 @@ static int __init mxser_init(void)
                MXSER_VERSION);
 
        /* Initialize the tty_driver structure */
-       memset(mxvar_sdriver, 0, sizeof(struct tty_driver));
        mxvar_sdriver->magic = TTY_DRIVER_MAGIC;
        mxvar_sdriver->name = "ttyM";
        mxvar_sdriver->major = ttymajor;
@@ -721,12 +720,6 @@ static int __init mxser_init(void)
        mxvar_sdriver->termios_locked = mxvar_termios_locked;
 
        mxvar_diagflag = 0;
-       memset(mxser_boards, 0, sizeof(mxser_boards));
-       memset(&mxvar_log, 0, sizeof(struct mxser_log));
-
-       memset(&mxser_msr, 0, sizeof(unsigned char) * (MXSER_PORTS + 1));
-       memset(&mon_data_ext, 0, sizeof(struct mxser_mon_ext));
-       memset(&mxser_set_baud_method, 0, sizeof(int) * (MXSER_PORTS + 1));
 
        m = 0;
        /* Start finding ISA boards here */