]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[NETFILTER]: fix list traversal order in ctnetlink
authorPablo Neira Ayuso <pablo@eurodev.net>
Wed, 10 Aug 2005 03:06:42 +0000 (20:06 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Mon, 29 Aug 2005 22:40:25 +0000 (15:40 -0700)
commitff21d5774b4a186c98be6398eacde75d896db804
treef2b1da2cec09742fd9b5e90479e2ebb2068ea1e8
parent28b19d99ac6d92e4fb2fe34144c495019a638a64
[NETFILTER]: fix list traversal order in ctnetlink

Currently conntracks are inserted after the head. That means that
conntracks are sorted from the biggest to the smallest id. This happens
because we use list_prepend (list_add) instead list_add_tail. This can
result in problems during the list iteration.

                 list_for_each(i, &ip_conntrack_hash[cb->args[0]]) {
                         h = (struct ip_conntrack_tuple_hash *) i;
                         if (DIRECTION(h) != IP_CT_DIR_ORIGINAL)
                                 continue;
                         ct = tuplehash_to_ctrack(h);
                         if (ct->id <= *id)
                                 continue;

In that case just the first conntrack in the bucket will be dumped. To
fix this, we iterate the list from the tail to the head via
list_for_each_prev. Same thing for the list of expectations.

Signed-off-by: Pablo Neira Ayuso <pablo@eurodev.net>
Signed-off-by: Harald Welte <laforge@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/netfilter/ip_conntrack_netlink.c