]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
KVM: make kvm_unregister_irq_ack_notifier() safe
authorMark McLoughlin <markmc@redhat.com>
Mon, 1 Dec 2008 13:57:46 +0000 (13:57 +0000)
committerAvi Kivity <avi@redhat.com>
Wed, 31 Dec 2008 14:55:06 +0000 (16:55 +0200)
commitfdd897e6b5253a45b633f7d334cf3e150bbaf386
tree2a6d5c59d782c49f20d01578525eb9ec201bb35a
parent844c7a9ff404d8fc88bb77b06461644621d2c985
KVM: make kvm_unregister_irq_ack_notifier() safe

We never pass a NULL notifier pointer here, but we may well
pass a notifier struct which hasn't previously been
registered.

Guard against this by using hlist_del_init() which will
not do anything if the node hasn't been added to the list
and, when removing the node, will ensure that a subsequent
call to hlist_del_init() will be fine too.

Fixes an oops seen when an assigned device is freed before
and IRQ is assigned to it.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
virt/kvm/irq_comm.c