]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
eCryptfs: Regression in unencrypted filename symlinks
authorTyler Hicks <tyhicks@linux.vnet.ibm.com>
Sat, 7 Feb 2009 00:06:51 +0000 (18:06 -0600)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 7 Feb 2009 02:36:40 +0000 (18:36 -0800)
commitfd9fc842bbab0cb5560b0d52ce4598c898707863
treeff8fc9b1c964debf18ba662558b26bf7bb7513cc
parenteeb94855beeb7fde5f9e2ed72fe6a8b24cd5a3c7
eCryptfs: Regression in unencrypted filename symlinks

The addition of filename encryption caused a regression in unencrypted
filename symlink support.  ecryptfs_copy_filename() is used when dealing
with unencrypted filenames and it reported that the new, copied filename
was a character longer than it should have been.

This caused the return value of readlink() to count the NULL byte of the
symlink target.  Most applications don't care about the extra NULL byte,
but a version control system (bzr) helped in discovering the bug.

Signed-off-by: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/ecryptfs/crypto.c