]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] sanitize handling of shared descriptor tables in failing execve()
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 22 Apr 2008 09:11:59 +0000 (05:11 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Fri, 25 Apr 2008 13:23:53 +0000 (09:23 -0400)
commitfd8328be874f4190a811c58cd4778ec2c74d2c05
treeb44ae8e99ce96a1a4739b04d4d1a23c40ab8b163
parent6b335d9c80d7f3c2a3f6545f664ae9007a0f3821
[PATCH] sanitize handling of shared descriptor tables in failing execve()

* unshare_files() can fail; doing it after irreversible actions is wrong
  and de_thread() is certainly irreversible.
* since we do it unconditionally anyway, we might as well do it in do_execve()
  and save ourselves the PITA in binfmt handlers, etc.
* while we are at it, binfmt_som actually leaked files_struct on failure.

As a side benefit, unshare_files(), put_files_struct() and reset_files_struct()
become unexported.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/binfmt_elf.c
fs/binfmt_misc.c
fs/binfmt_som.c
fs/exec.c
kernel/exit.c
kernel/fork.c