]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
Fix a potential issue in mpc52xx uart driver
authorAndrew Liu <shengping.liu@windriver.com>
Tue, 29 Apr 2008 07:36:25 +0000 (17:36 +1000)
committerGrant Likely <grant.likely@secretlab.ca>
Thu, 1 May 2008 17:59:12 +0000 (11:59 -0600)
commitfbe543b412cef02350fab35526a6d4dc3d20d182
treea47e56379bc0611e1d15e6318c58d9a3bcd23478
parent80791be11145f7dd7f68c84741fc66e5164b7353
Fix a potential issue in mpc52xx uart driver

mpc52xx_uart_int and __uart_put_char both try to acquire the
port->lock. Therefore the function sequence of:

mpc52xx_uart_int--> ...-->flush_to_ldisc-->...-->__uart_put_char

can potentially trigger a deadlock. To avoid this deadlock a fix
similar to that found in the 8250.c serial driver is applied. The
deadlock is avoided by releasing the lock before pushing a buffer
and reacquiring it when completed.

Signed-off-by: Andrew Liu <shengping.liu@windriver.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
drivers/serial/mpc52xx_uart.c