]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] pci_iomap_regions() error handling fix
authorFrederik Deweerdt <deweerdt@free.fr>
Fri, 16 Feb 2007 09:27:15 +0000 (01:27 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Fri, 16 Feb 2007 16:13:55 +0000 (08:13 -0800)
commitfb4d64e78ceab77cf20f7796f74aa10ebe862032
tree99266c49cd77b6ac15f5938535d7bc707113ebd5
parentf5de611148c8370cbe50796ca5567ca624b99686
[PATCH] pci_iomap_regions() error handling fix

It appears that the pcim_iomap_regions() function doesn't get the error
handling right. It BUGs early at boot with a backtrace along the lines of:

ahci_init
pci_register_driver
driver_register
[...]
ahci_init_one
pcim_iomap_region
pcim_iounmap

The following patch allows me to boot. Only the if(mask..) continue;
part fixes the problem actually, the gotos where changed so that we
don't try to unmap something we couldn't map anyway.

Signed-off-by: Frederik Deweerdt <frederik.deweerdt@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
lib/devres.c