]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
smsc911x: improve EEPROM loading timeout logic in open
authorSteve Glendinning <steve.glendinning@smsc.com>
Wed, 4 Mar 2009 07:33:25 +0000 (07:33 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 13 Mar 2009 19:14:11 +0000 (12:14 -0700)
commitf7efb6ccc2113911e4e064f78bcd0343c4673038
tree3856f2a8ffa3ac0efc6da507b194f93183b2b0d6
parent8dacd548129d03e87751f75ea83b42a8a17ee651
smsc911x: improve EEPROM loading timeout logic in open

This patch from Juha Leppanen suppresses a false warning if the eeprom
load succeeds on the very last attempt.

Juha> In function smsc911x_open smsc911x_reg_read+udelay can be run 50
Juha> times with timeout reaching -1, and the following if statetement
Juha> does not catch the timeout and no warning is issued. Also if the
Juha> 50th smsc911x_reg_read is GOOD, loop is exited with timeout as 0
Juha> and bogus warning issued.  Replace testing order and --timeout
Juha> instead of timeout-- and now max 50 smsc911x_reg_read's are done,
Juha> with max 49 udelays.

Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/smsc911x.c