]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] ISDN: Avoid a potential NULL ptr deref in ippp
authorJesper Juhl <jesper.juhl@gmail.com>
Fri, 8 Dec 2006 10:39:34 +0000 (02:39 -0800)
committerLinus Torvalds <torvalds@woody.osdl.org>
Fri, 8 Dec 2006 16:29:01 +0000 (08:29 -0800)
commitf6e2cdc8aa395ea813603bfd81b70b5c461a8ebf
treecc6c66b9b53bfd313114c4b464223bef992449b4
parentba6d14aff4112b9518856d2d3979a386cb3a2945
[PATCH] ISDN: Avoid a potential NULL ptr deref in ippp

There's a potential problem in isdn_ppp.c::isdn_ppp_decompress().
dev_alloc_skb() may fail and return NULL. If it does we will be passing a
NULL skb_out to ipc->decompress() and may also end up
dereferencing a NULL pointer at

    *proto = isdn_ppp_strip_proto(skb_out);

Correct this by testing 'skb_out' against NULL early and bail out.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Karsten Keil <kkeil@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/isdn/i4l/isdn_ppp.c