]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
IB/mlx4: Use kzalloc() for new QPs so flags are initialized to 0
authorEli Cohen <eli@mellanox.co.il>
Tue, 15 Jul 2008 06:48:53 +0000 (23:48 -0700)
committerRoland Dreier <rolandd@cisco.com>
Tue, 15 Jul 2008 06:48:53 +0000 (23:48 -0700)
commitf507d28bff0601f1a8a96b7939fa3855c50d25b6
treecc123185fdd19bac8c6309adeef0e39b47ef9b04
parent2d92865158d0e21ef4350703af64bc2a610d81d3
IB/mlx4: Use kzalloc() for new QPs so flags are initialized to 0

Current code uses kmalloc() and then just does a bitwise OR operation on
qp->flags in create_qp_common(), which means that qp->flags may
potentially have some unintended bits set.  This patch uses kzalloc()
and avoids further explicit clearing of structure members, which also
shrinks the code:

add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-65 (-65)
function                                     old     new   delta
create_qp_common                            2024    1959     -65

Signed-off-by: Eli Cohen <eli@mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/hw/mlx4/qp.c