]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[NETNS]: Simplify the network namespace list locking rules.
authorEric W. Biederman <ebiederm@xmission.com>
Thu, 27 Sep 2007 05:40:08 +0000 (22:40 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Wed, 10 Oct 2007 23:52:55 +0000 (16:52 -0700)
commitf4618d39a34dab316090263b42cd8799f31ce277
tree75db202b492da1797145fde455b0c4c89cf41767
parent32db927686f6d475fc05b6229f82ed576c0c8096
[NETNS]: Simplify the network namespace list locking rules.

Denis V. Lunev <den@sw.ru> noticed that the locking rules
for the network namespace list are over complicated and broken.

In particular the current register_netdev_notifier currently
does not take any lock making the for_each_net iteration racy
with network namespace creation and destruction. Oops.

The fact that we need to use for_each_net in rtnl_unlock() when
the rtnetlink support becomes per network namespace makes designing
the proper locking tricky.  In addition we need to be able to call
rtnl_lock() and rtnl_unlock() when we have the net_mutex held.

After thinking about it and looking at the alternatives carefully
it looks like the simplest and most maintainable solution is
to remove net_list_mutex altogether, and to use the rtnl_mutex instead.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/net_namespace.h
net/core/net_namespace.c