]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
drivers/net/hamradio: Move a dereference below a NULL test
authorJulia Lawall <julia@diku.dk>
Tue, 16 Dec 2008 23:43:29 +0000 (15:43 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 16 Dec 2008 23:43:29 +0000 (15:43 -0800)
commitf40e0638237a2d3e2ce8bedf3af4b3c02cf6fff7
treec70b1a86681bd827fd0d7028cef391042f344e79
parentf162e97d778ec29492be8eb9bbecb65be976b7c8
drivers/net/hamradio: Move a dereference below a NULL test

In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/hamradio/mkiss.c