]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
powerpc/pseries: Check for GIQ indicator before calling set-indicator
authorNathan Lynch <ntl@pobox.com>
Thu, 11 Dec 2008 09:14:25 +0000 (09:14 +0000)
committerPaul Mackerras <paulus@samba.org>
Tue, 16 Dec 2008 04:53:13 +0000 (15:53 +1100)
commitedc72ac4a0894247a6d3f1157a8ec8d603fff52d
tree9d712442158c4276f1af551c518c4247da6ff2ba
parent6ff04c53db97c896ecca9374c0be4f681cf5fe50
powerpc/pseries: Check for GIQ indicator before calling set-indicator

Since "Factor out cpu joining/unjoining the GIQ"
(b4963255ad5a426f04a0bb15c4315fa4bb40cde9) the WARN_ON in
xics_set_cpu_giq() is being triggered during boot on JS20 because the
GIQ indicator is not available on that platform.  While the warning is
harmless and the system runs normally, it's nicer to check for the
existence of the indicator before trying to manipulate it.

Implement rtas_indicator_present(), which searches the
/rtas/rtas-indicators property for the given indicator token, and use
this function in xics_set_cpu_giq().

Also use a WARN statement in xics_set_cpu_giq to get better
information on failure.

Signed-off-by: Nathan Lynch <ntl@pobox.com>
Acked-by: Milton Miller <miltonm@bga.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/include/asm/rtas.h
arch/powerpc/kernel/rtas.c
arch/powerpc/platforms/pseries/xics.c