]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
PCI: remove dynids.use_driver_data
authorMilton Miller <miltonm@bga.com>
Thu, 10 Jul 2008 21:29:37 +0000 (16:29 -0500)
committerJesse Barnes <jbarnes@virtuousgeek.org>
Mon, 20 Oct 2008 17:48:34 +0000 (10:48 -0700)
commitedbc25caaa492a82e19baa915f1f6b0a0db6554d
tree967dbd4f8d35fd8532a612fef55691586b831965
parent7d67474e506598fe26e0c262acf02132dc730517
PCI: remove dynids.use_driver_data

The driver flag dynids.use_driver_data is almost consistently not set,
and causes more problems than it solves.  It was initially intended as a
flag to indicate whether a driver's usage of driver_data had been
carefully inspected and was ready for values from userspace.  That audit
was never done, so most drivers just get a 0 for driver_data when new
IDs are added from userspace via sysfs.  So remove the flag, allowing
drivers to see the data directly (a followon patch validates the passed
driver_data value against what the drivers expect).

Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Milton Miller <miltonm@bga.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
drivers/i2c/busses/i2c-amd756.c
drivers/i2c/busses/i2c-viapro.c
drivers/pci/pci-driver.c
drivers/scsi/ipr.c
include/linux/pci.h