]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
Staging: at76_usb: fix bugs introduced by "Staging: at76_usb: cleanup dma on stack...
authorJason Andryuk <jandryuk@gmail.com>
Fri, 30 Jan 2009 14:05:03 +0000 (09:05 -0500)
committerGreg Kroah-Hartman <gregkh@kvm.kroah.org>
Mon, 9 Feb 2009 19:26:18 +0000 (11:26 -0800)
commitea8f9fe634da9042c01ca2f4e459a7b187056021
tree3b6b7c7e98b619c73c6937d2ba3221da99e6163d
parent89cb7e7fd6c0917bb9236ea48bf538d4668ed009
Staging: at76_usb: fix bugs introduced by "Staging: at76_usb: cleanup dma on stack issues"

Tracking down the firmware loading problem led to this commit.

$ git bisect bad
0d1d1424330cc1934f2b2742f0cfa2c31e6a250b is first bad commit
commit 0d1d1424330cc1934f2b2742f0cfa2c31e6a250b
Author: Oliver Neukum <oliver@neukum.org>
Date:   Thu Dec 18 13:16:40 2008 +0100

    Staging: at76_usb: cleanup dma on stack issues

    - no DMA on stack
    - cleanup unclear endianness issue

Signed-off-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
:040000 040000 c4fee9ea0fef25926229d810d19dc2f89cca9401
8b165a35d16280d2413b2700a6080ef290ca1009 M drivers

The "no DMA on stack" conversion was incomplete with respect to
updating the arguments passed to usb_control_msg.  The value 40 is
hardcoded as it was prior to conversion.

The driver can now load firmware, but is not fully functional.

Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
Cc: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/at76_usb/at76_usb.c