]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
r8169: revert "r8169: read MAC address from EEPROM on init (2nd attempt)"
authorfrançois romieu <romieu@fr.zoreil.com>
Sun, 15 Mar 2009 01:10:50 +0000 (01:10 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 16 Mar 2009 03:03:10 +0000 (20:03 -0700)
commitea8dbdd17099a9a5864ebd4c87e01e657b19c7ab
tree8d30419e013f0c7e75545e0c7ad03140a2acfc47
parent97d477a914b146e7e6722ded21afa79886ae8ccd
r8169: revert "r8169: read MAC address from EEPROM on init (2nd attempt)"

It fails on the following systems:
- RTL8169sc/8110sc (XID 18000000)
  reported by Tim Durack <tdurack@gmail.com> (x86)
- RTL8169sb/8110sb (XID 10000000)
  reported by Mikael Pettersson <mikpe@it.uu.se> (ARM)

The patch appeared to work on x86 for the following systems:
RTL8169sb/8110sb 10000000 PCI   (EXT)
RTL8110s         04000000 PCI   (EXT)
RTL8102e         24a00000 PCI-E (LOM)
RTL8168c/8111c   3c2000c0 PCI-E (LOM)
RTL8168b/8111b   38000000 PCI-E (LOM)
RTL8168b/8111b   38000000 PCI-E (EXT)

The patch exposes two problems:
1) while not completely wrong, mac addresses are not read correctly
   from the EEPROM
2) the MAC address registers are not correctly set

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Tested-by: Mikael Pettersson <mikpe@it.uu.se>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/r8169.c