]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
drivers: fix dma_get_required_mask
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Sun, 9 Mar 2008 16:57:56 +0000 (11:57 -0500)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 10 Mar 2008 23:33:33 +0000 (16:33 -0700)
commite88a0c2ca81207a75afe5bbb8020541dabf606ac
treeb92a158720c3c6e3eb45380849bf14585b7c9d64
parentfbab976d7ce4556d4212d554f766dae461d22e16
drivers: fix dma_get_required_mask

There's a bug in the current implementation of dma_get_required_mask()
where it ands the returned mask with the current device mask.  This
rather defeats the purpose if you're using the call to determine what
your mask should be (since you will at that time have the default
DMA_32BIT_MASK).  This bug results in any driver that uses this function
*always* getting a 32 bit mask, which is wrong.

Fix by removing the and with dev->dma_mask.

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/base/platform.c