]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
PCI: PCIe portdrv: Fix suspend and resume of PCI Express port services
authorRafael J. Wysocki <rjw@sisk.pl>
Thu, 1 Jan 2009 18:51:15 +0000 (19:51 +0100)
committerJesse Barnes <jbarnes@virtuousgeek.org>
Wed, 7 Jan 2009 19:13:26 +0000 (11:13 -0800)
commite7ae88486670f3904f187d0fff9dcf469bcdd8ba
treec2a1ff5cb3a8b24778789720f9a64f59e679dfd0
parentfacf6d1627a33badbbc154524c4a2c73c51bdc99
PCI: PCIe portdrv: Fix suspend and resume of PCI Express port services

There is a problem with the suspend and resume of PCI Express port
service devices that the ->suspend() and ->resume() routines of each
service device are called twice in each suspend-resume cycle, which
is obviously wrong.

The scenario is that first, the PCI Express port driver calls
suspend and resume routines of each port service driver from its
pcie_portdrv_suspend() and pcie_portdrv_resume() callbacks,
respectively (which is correct), and second, the pcie_port_bus_type
driver calls them from its ->suspend() and ->resume() callbacks
(which is not correct, because it doesn't happen at the right time).

The solution is to remove the ->suspend() and ->resume() callbacks
from pcie_port_bus_type and the associated functions.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
drivers/pci/pcie/portdrv_bus.c
drivers/pci/pcie/portdrv_core.c