]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
ide: Two fixes regarding memory allocation
authorElias Oltmanns <eo@nebensachen.de>
Mon, 13 Oct 2008 19:39:45 +0000 (21:39 +0200)
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Mon, 13 Oct 2008 19:39:45 +0000 (21:39 +0200)
commite415e495f8294e536e09e6a15fba897cce4c0748
tree7a1a9c82d1b0faedf2454a76027df6e1fff4a8fb
parent06b89518fa69fb7243dc98c31f9a9cfa61bfe788
ide: Two fixes regarding memory allocation

In function ide_devset_execute() we should use __GFP_WAIT rather than
GFP_KERNEL. Also, the allocation cannot possibly fail at that point.
More importantly, there is a potential memory leak in the device probing
code. The infrastructure seems rather complex and I hope I haven't messed
anything up by trying to fix this.

Signed-off-by: Elias Oltmanns <eo@nebensachen.de>
[bart: remove superfluous ide_lock taking]
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
drivers/ide/ide-io.c
drivers/ide/ide-probe.c