]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
USB: fix usb_serial_suspend(): buggy code
authorOliver Neukum <oneukum@suse.de>
Mon, 23 Jul 2007 06:58:39 +0000 (08:58 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 30 Jul 2007 20:27:45 +0000 (13:27 -0700)
commite31c18804f584dd838a752f6628e8c15bd7a3372
treeabead87733ffe5e3da890058d523851e849794f1
parent209b3cfd538e7d56d228cf6daf0b27e2cc26c6c2
USB: fix usb_serial_suspend(): buggy code

Am Montag 23 Juli 2007 schrieb Adrian Bunk:
> Commit ec22559e0b7a05283a3413bda5d177e42c950e23 added the following
> function to drivers/usb/serial/usb-serial.c:
>
[..]
>
> The Coverity checker spotted the inconsequent NULL checking for "serial".
>
> Looking at the code it also doesn't seem to have been intended to always
> return 0.

Coverity is right. The check for NULL is wrongly done and the error
return is lost.

Signed-off-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/serial/usb-serial.c