]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
dm9000: locking bugfix
authorDavid Brownell <dbrownell@users.sourceforge.net>
Mon, 23 Mar 2009 04:28:39 +0000 (21:28 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 23 Mar 2009 04:28:39 +0000 (21:28 -0700)
commite3162d381fc359ebe5c98a3e216888a7cb200051
treed3affce735bf848e98150541fe2c487319a29bd0
parent6580f57d485f70851218813fa053d971915f61fb
dm9000: locking bugfix

This fixes a locking bug in the dm9000 driver.  It calls
request_irq() without setting IRQF_DISABLED ... which is
correct for handlers that support IRQ sharing, since that
behavior is not guaranteed for shared IRQs.  However, its
IRQ handler then wrongly assumes that IRQs are blocked.
So the fix just uses the right spinlock primitives in the
IRQ handler.

NOTE:  this is a classic example of the type of bug which
lockdep currently masks by forcibly setting IRQF_DISABLED
on IRQ handlers that did not request that flag.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dm9000.c