]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[SCSI] aic94xx: fix TMF ascb handling to prevent sequencer panic
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Sun, 24 Feb 2008 05:44:19 +0000 (23:44 -0600)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Sun, 24 Feb 2008 06:40:57 +0000 (00:40 -0600)
commite2396f1e4ecd438a15fa653a028b93e95013caa3
tree8cc11b28b64fbf3a7a22d1636467d35174092e27
parent8de3ef25a1fcd28d270b69417a41b424826d4f89
[SCSI] aic94xx: fix TMF ascb handling to prevent sequencer panic

This is a particularly nasty bug.  The problem is that if any internal
ascb times out, currently we free it even though it's pending at the
sequencer.  This results in the sequencer getting terminally confused
and the error message:

BUG:sequencer:dl:no ascb

Being returned when it comes back.  The way to fix this is to manage
freeing the ascb from the tasklet completion routine, so that we only
free it when the sequencer actually returns it.  The code is also
altered to use on stack completions and transfer variables.

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/aic94xx/aic94xx_hwi.h
drivers/scsi/aic94xx/aic94xx_task.c
drivers/scsi/aic94xx/aic94xx_tmf.c