]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
sctp: Add check for the TSN field of the SHUTDOWN chunk
authorWei Yongjun <yjwei@cn.fujitsu.com>
Thu, 23 Oct 2008 08:00:21 +0000 (01:00 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 23 Oct 2008 08:00:21 +0000 (01:00 -0700)
commitdf10eec476f2045a2ef5f85d97c7b47d992d7f7b
tree22d7855af143100359be8ef568f85dd3fb1d636b
parent91bd6b1e030266cf87d3f567b49f0fa60a7318ba
sctp: Add check for the TSN field of the SHUTDOWN chunk

If SHUTDOWN chunk is received Cumulative TSN Ack beyond the max tsn currently
send, SHUTDOWN chunk be accepted and the association will be broken. New data
is send, but after received SACK it will be drop because TSN in SACK is less
than the Cumulative TSN, data will be retrans again and again even if correct
SACK is received.

The packet sequence is like this:

Endpoint A                       Endpoint B       ULP
(ESTABLISHED)                    (ESTABLISHED)

               <-----------      DATA (TSN=x-1)

               <-----------      DATA (TSN=x)

  SHUTDOWN     ----------->      (Now Cumulative TSN=x+1000)
  (TSN=x+1000)
               <-----------      DATA (TSN=x+1)

  SACK         ----------->      drop the SACK
  (TSN=x+1)
               <-----------      DATA (TSN=x+1)(retrans)

This patch fix this problem by terminating the association and respond to
the sender with an ABORT.

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/sm_statefuns.c