]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[IA64] ia64: simplify and fix udelay()
authorhawkes@sgi.com <hawkes@sgi.com>
Tue, 14 Feb 2006 18:40:17 +0000 (10:40 -0800)
committerTony Luck <tony.luck@intel.com>
Wed, 15 Feb 2006 21:37:04 +0000 (13:37 -0800)
commitdefbb2c929cbe89dc92239b303cd33d3c85e9a83
tree85dbcfa407d4bfaecbce4f3556a73033b8f70caf
parent4c2cd96696ae0896ce4bcf725b9f0eaffafeb640
[IA64] ia64: simplify and fix udelay()

The original ia64 udelay() was simple, but flawed for platforms without
synchronized ITCs:  a preemption and migration to another CPU during the
while-loop likely resulted in too-early termination or very, very
lengthy looping.

The first fix (now in 2.6.15) broke the delay loop into smaller,
non-preemptible chunks, reenabling preemption between the chunks.  This
fix is flawed in that the total udelay is computed to be the sum of just
the non-premptible while-loop pieces, i.e., not counting the time spent
in the interim preemptible periods.  If an interrupt or a migration
occurs during one of these interim periods, then that time is invisible
and only serves to lengthen the effective udelay().

This new fix backs out the current flawed fix and returns to a simple
udelay(), fully preemptible and interruptible.  It implements two simple
alternative udelay() routines:  one a default generic version that uses
ia64_get_itc(), and the other an sn-specific version that uses that
platform's RTC.

Signed-off-by: John Hawkes <hawkes@sgi.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
arch/ia64/kernel/time.c
arch/ia64/sn/kernel/sn2/timer.c
include/asm-ia64/timex.h