]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
USB HID: fix a possible NULL pointer dereference when we fail to allocate memory
authorJesper Juhl <jesper.juhl@gmail.com>
Mon, 30 Jul 2007 13:15:26 +0000 (15:15 +0200)
committerJiri Kosina <jkosina@suse.cz>
Thu, 2 Aug 2007 11:48:03 +0000 (13:48 +0200)
commitde1a7b03282310d143cb0add74e909daffedda01
treeb65e3873d4805595a242257d06524982e960edb2
parent04a9b7ffceff4337d9e63476b5c71e9b79249969
USB HID: fix a possible NULL pointer dereference when we fail to allocate memory

If, in usb_hid_configure(), we fail to allocate storage for 'usbhid',
 "if (!(usbhid = kzalloc(sizeof(struct usbhid_device), GFP_KERNEL)))",
then we'll jump to the 'fail:' label where we have this code:
        usb_free_urb(usbhid->urbin);
        usb_free_urb(usbhid->urbout);
        usb_free_urb(usbhid->urbctrl);
Since we got here because we couldn't allocate storage for 'usbhid',
what we have here is a NULL pointer dereference - ouch...

This patch solves that little problem by adding a new
'fail_no_usbhid:' label after the problematic calls to
usb_free_urb() and jumps to that one instead, in the problem case.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/usbhid/hid-core.c