]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
drivers/hvc: Add missing of_node_put
authorNicolas Palix <npalix@diku.dk>
Tue, 2 Dec 2008 03:38:55 +0000 (03:38 +0000)
committerPaul Mackerras <paulus@samba.org>
Wed, 3 Dec 2008 10:04:09 +0000 (21:04 +1100)
commitdc42149fccda63a5d2fa4457808c3489a5111c5e
tree93cbbb568c32ac983cf7795d113ca00bc481b47e
parentb908b53d580c3e9aba81ebe3339c5b7b4fa8031d
drivers/hvc: Add missing of_node_put

of_node_put is needed before discarding a value received from
of_find_node_by_name, e.g., in error handling code or when the device
node is no longer used.

The semantic match that catches the bug is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression struct device_node *n;
position p1, p2;
statement S1,S2;
expression E,E1;
expression *ptr != NULL;
@@

(
if (!(n@p1 = of_find_node_by_name(...))) S1
|
n@p1 = of_find_node_by_name(...)
)
<... when != of_node_put(n)
    when != if (...) { <+... of_node_put(n) ...+> }
    when != true !n  || ...
    when != n = E
    when != E = n
if (!n || ...) S2
...>
(
  return \(0\|<+...n...+>\|ptr\);
|
return@p2 ...;
|
n = E1
|
E1 = n
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s of_find_node_by_name %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Nicolas Palix <npalix@diku.dk>
Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
drivers/char/hvc_iseries.c
drivers/char/hvc_vio.c