]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
pccard_store_cis: fix wrong error handling
authorLinus Torvalds <torvalds@g5.osdl.org>
Sun, 1 Oct 2006 20:17:44 +0000 (13:17 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sun, 1 Oct 2006 20:17:44 +0000 (13:17 -0700)
commitd834c16516d1ebec4766fc58c059bf01311e6045
tree8095561ebb7b01bd21e1f6ca548a3ea0b2bca675
parent4e9011d50d77ce7d234272e203235d8ecffd61a1
pccard_store_cis: fix wrong error handling

The test for the error from pcmcia_replace_cis() was incorrect, and
would always trigger (because if an error didn't happen, the "ret" value
would not be zero, it would be the passed-in count).

Reported and debugged by Fabrice Bellet <fabrice@bellet.info>

Rather than just fix the single broken test, make the code in question
use an understandable code-sequence instead, fixing the whole function
to be more readable.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/pcmcia/socket_sysfs.c