]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
ehea: use get_zeroed_page for alignment-sensitive allocation
authorNathan Lynch <ntl@pobox.com>
Mon, 22 Dec 2008 08:42:11 +0000 (08:42 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Dec 2008 02:32:57 +0000 (18:32 -0800)
commitd76e56b4c620c959fa8346c08d24ee4b2783a564
tree93e7b2b4eb3ec0065eaccdb5aa58a98c073f7f6d
parent26c743bed9b0dc83dc736c68d2a3e7494a9790ad
ehea: use get_zeroed_page for alignment-sensitive allocation

With slub debug enabled, I see the following errors and crash with
2.6.28-rc9:

IBM eHEA ethernet device driver (Release EHEA_0095)
ehea: Error in ehea_h_register_rpage_mr: not on pageboundary
ehea: Error in ehea_reg_mr_section: register_rpage_mr failed
ehea: Error in ehea_reg_kernel_mr: registering mr failed
ehea: Error in ehea_setup_ports: creating MR failed
ehea 23c00100.lhea: setup_ports failed
Unable to handle kernel paging request for data at address 0x6b6b6b6b6b6bbdcb
Faulting instruction address: 0xd000000000064a24
cpu 0x0: Vector: 300 (Data Access) at [c0000000740e7190]
    pc: d000000000064a24: .ehea_update_firmware_handles+0x84/0x47c [ehea]
    lr: d00000000006df34: .ehea_probe_adapter+0x35c/0x39c [ehea]
    sp: c0000000740e7410
   msr: 8000000000009032
   dar: 6b6b6b6b6b6bbdcb
 dsisr: 40000000
  current = 0xc000000074233780
  paca    = 0xc0000000008a3300
    pid   = 2046, comm = modprobe
enter ? for help
[c0000000740e74f0d00000000006df34 .ehea_probe_adapter+0x35c/0x39c [ehea]
[c0000000740e75a0c00000000041d5a4 .of_platform_device_probe+0x78/0xb0
[c0000000740e7630c0000000002d8b38 .driver_probe_device+0x13c/0x200
[c0000000740e76c0c0000000002d8c90 .__driver_attach+0x94/0xd8
[c0000000740e7750c0000000002d7d64 .bus_for_each_dev+0x80/0xd8
[c0000000740e7800c0000000002d889c .driver_attach+0x28/0x40
[c0000000740e7880c0000000002d8340 .bus_add_driver+0xd4/0x284
[c0000000740e7920c0000000002d90a0 .driver_register+0xc4/0x198
[c0000000740e79d0c00000000041d45c .of_register_driver+0x4c/0x60
[c0000000740e7a50c000000000020ef8 .ibmebus_register_driver+0x30/0x4c
[c0000000740e7ae0d00000000006e108 .ehea_module_init+0x194/0x208c [ehea]
[c0000000740e7b90c000000000009028 .do_one_initcall+0x90/0x1ac
[c0000000740e7d90c00000000008619c .sys_init_module+0xc4/0x200
[c0000000740e7e30c0000000000084ac syscall_exit+0x0/0x40

(When slub debug is disabled it works fine.)

PAGE_SIZE allocations via slab are not guaranteed to be page-aligned;
use get_zeroed_page for the 'pt' buffer (I don't really know what this
is, only that it is passed to firmware and that the first error
message complains about its alignment).  This allows the system to
boot.

Signed-off-by: Nathan Lynch <ntl@pobox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ehea/ehea_qmr.c