]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[POWERPC] spufs: fix context destruction during psmap fault
authorJeremy Kerr <jk@ozlabs.org>
Tue, 26 Feb 2008 02:31:42 +0000 (13:31 +1100)
committerJeremy Kerr <jk@ozlabs.org>
Wed, 27 Feb 2008 07:47:53 +0000 (18:47 +1100)
commitd58831375d68a3bd39d5ebab9eca711fbb4ee108
treea232a5cb9715a9a4740e21a4f0fc757e1286a7d0
parent61b36fc1f7d511132b1dd1422c29c7a8f26d77db
[POWERPC] spufs: fix context destruction during psmap fault

We have a small window where a spu context may be destroyed while
we're servicing a page fault (from another thread) to the context's
problem state mapping.

After we up_read() the mmap_sem, it's possible that the context is
destroyed by its owning thread, and so the later references to ctx
are invalid. This can maifest as a deadlock on the (now free()-ed)
context state mutex.

This change adds a reference to the context before we release the
mmap_sem, so that the context cannot be destroyed.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
arch/powerpc/platforms/cell/spufs/file.c