]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] knfsd: Fix stale file handle problem with subtree_checking.
authorNeilBrown <neilb@suse.de>
Sun, 30 Jul 2006 10:03:16 +0000 (03:03 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Mon, 31 Jul 2006 20:28:37 +0000 (13:28 -0700)
commitd1bbf14f37261c2c0dba71404602e1ddcec069d2
tree7b01141c31b73f277079cbcdb88be6ac8da2add1
parenta5ca63cb60892c1703998daf80d2d1b04cb70103
[PATCH] knfsd: Fix stale file handle problem with subtree_checking.

A recent commit (7fc90ec93a5eb71f4b08403baf5ba7176b3ec6b1) moved the
call to nfsd_setuser out of the 'find a dentry for a filehandle' branch
of fh_verify so that it would always be called.

This had the unfortunately side-effect of moving *after* the call to
decode_fh, so the prober fsuid was not set when nfsd_acceptable was called,
the 'permission' check did the wrong thing.

This patch moves the nfsd_setuser call back where it was, and add as call
in the other branch of the if.

Cc: "J. Bruce Fields" <bfields@fieldses.org>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/nfsd/nfsfh.c