]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] CPU hotplug: call check_tsc_sync_source() with irqs off
authorIngo Molnar <mingo@elte.hu>
Wed, 7 Mar 2007 17:12:31 +0000 (18:12 +0100)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Wed, 7 Mar 2007 18:07:24 +0000 (10:07 -0800)
commitd04f41e35343f1d788551fd3f753f51794f4afcf
tree50f22b1deab312476254868e8ec8c0c592c3d3e0
parent08e15e81a40e3241ce93b4a43886f3abda184aa6
[PATCH] CPU hotplug: call check_tsc_sync_source() with irqs off

check_tsc_sync_source() depends on being called with irqs disabled (it
checks whether the TSC is coherent across two specific CPUs). This is
incidentally true during bootup, but not during cpu hotplug __cpu_up().
This got found via smp_processor_id() debugging.

disable irqs explicitly and remove the unconditional enabling of
interrupts. Add touch_nmi_watchdog() to the cpu_online_map busy loop.

this bug is present both on i386 and on x86_64.

Reported-by: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/i386/kernel/smpboot.c
arch/x86_64/kernel/smpboot.c