]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
fix allmodconfig breakage
authorAl Viro <viro@ZenIV.linux.org.uk>
Sun, 26 Oct 2008 05:12:34 +0000 (05:12 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 26 Oct 2008 16:35:05 +0000 (09:35 -0700)
commitce97e13e52848c6388598696b7d44748598db759
tree2baccc7a0532aaee8afe42cca84e09732a131a2a
parent23cf24c0c83a5a6eb39b9fa4d3843a8b9414db40
fix allmodconfig breakage

If you use KCONFIG_ALLCONFIG (even with empty file) you get broken
allmodconfig/allyesconfig; CONFIG_MODULES gets turned off, with obvious
massive fallout.

Breakage had been introduced when conf_set_all_new_symbols() got used
for allmodconfig et.al.

What happens is that sym_calc_value(modules_sym) done in
conf_read_simple() sets SYMBOL_VALID on both modules_sym and MODULES.
When we get to conf_set_all_new_symbols(), we set sym->def[S_DEF_USER]
on everything, but it has no effect on sym->curr for the symbols that
already have SYMBOL_VALID - these are stuck.

Solution: use sym_clear_all_valid() in there.  Note that it makes
reevaluation of modules_sym redundant - sym_clear_all_valid() will do
that itself.

[ Fixes http://bugzilla.kernel.org/show_bug.cgi?id=11512, says Alexey ]

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Roman Zippel <zippel@linux-m68k.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
scripts/kconfig/confdata.c